Add codecov by Dreamsorcerer · Pull Request #1889 · dimensionalOS/dimos

Dreamsorcerer · 2026-04-21T16:05:28Z

Add codecov, so we can easily see coverage changes in each PR.

greptile-apps · 2026-04-21T16:07:08Z

Greptile Summary

This PR integrates Codecov into the CI pipeline by consolidating the test and coverage steps, adding OIDC-based upload actions for both coverage XML and JUnit test results, and introducing a .codecov.yml config targeting the dev branch. Most previous review findings (missing id-token: write, push-only gating, missing coverage combine, missing --junitxml) have been addressed in this revision.

Confidence Score: 4/5

Safe to merge with one minor remaining gap: the Upload coverage step lacks if: ${{ !cancelled() }}, so a mypy failure silently drops the coverage report.

All previous P1 findings (missing OIDC permission, push-only gating, missing coverage combine, missing junitxml) have been resolved. The one unfixed item from prior review threads keeps the ceiling at 4.

.github/workflows/ci.yml — the Upload coverage step condition.

Important Files Changed

Filename	Overview
.github/workflows/ci.yml	Consolidated test + coverage into a single step; added Codecov upload steps for coverage and test results; added `id-token: write`; removed push-only gating — most previous P1s addressed, one remaining (no `if: !cancelled()` on Upload coverage).
.codecov.yml	New Codecov config file setting default branch to `dev` and suppressing "missing data" errors on PRs with `require_head/base: false`.
pyproject.toml	Added `branch = true` to coverage run config and replaced `show_missing`/`skip_empty` with `exclude_also` patterns to filter boilerplate from reports.

Sequence Diagram

sequenceDiagram
    participant GH as GitHub Actions
    participant Runner as CI Runner
    participant Codecov as Codecov

    GH->>Runner: Trigger (push or pull_request)
    Runner->>Runner: Install dependencies
    Runner->>Runner: coverage run -m pytest --junitxml=junit.xml
    Runner->>Runner: coverage combine
    Runner->>Runner: coverage xml → coverage.xml
    Runner->>Runner: mypy (if: !cancelled)
    Runner->>Codecov: Upload coverage.xml (OIDC, fail_ci_if_error)
    Runner->>Codecov: Upload junit.xml test results (if: !cancelled)

_{Reviews (9): Last reviewed commit: "Merge branch 'dev' into codecov" | Re-trigger Greptile}

Updated coverage upload steps and adjusted paths.

codecov-commenter · 2026-05-01T19:04:43Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Co-authored-by: Sam Bull <aa6bs0@sambull.org>

Add coverage configuration options for branch, parallel, and exclusion patterns.

* perf(rerun): render voxel maps as Points3D spheres instead of Boxes3D (dimensionalOS#1793) * feat(api): add porcelain api with connect (dimensionalOS#1779) * fix(rerun): dimos-viewer version upgrade (dimensionalOS#1785) * Task: Add meaningful manipulation tests (dimensionalOS#1765) * feat: never leave child processes alive after the parent (dimensionalOS#1886) * Fix mac UDP (dimensionalOS#1789) * Remove sim from base install (dimensionalOS#1878) * fix(tests): fix flakey porcelain test (dimensionalOS#1900) * feat(go2): rage mode via webrtc (dimensionalOS#1903) * feat:rust native modules (dimensionalOS#1794) Co-authored-by: leshy <lesh@sysphere.org> * Feat/memory2 - plotting, examples, recorder module, semantic search (dimensionalOS#1769) Co-authored-by: RD <63036454+ruthwikdasyam@users.noreply.github.com> * fix attributes (dimensionalOS#1918) * Jeff/fix/rconnect2 (dimensionalOS#1784) * fix(types): resolve mypy 3.10 errors (dimensionalOS#1921) * feat(go2): go2 SDK adapter + nix cyclonedds setup (dimensionalOS#1885) Co-authored-by: Mustafa Bhadsorawala <39084056+mustafab0@users.noreply.github.com> * Revert "Jeff/fix/rconnect2" (dimensionalOS#1924) * feat(modules): async modules (dimensionalOS#1920) * chore(logging): enforce usage of setup_logger (dimensionalOS#1895) * feat(api): peek_stream (dimensionalOS#1909) * CI/macos: skip failing tests (dimensionalOS#1944) * fix(ci): restrict code-cleanup workflow to Linux runners only (dimensionalOS#1948) * Fix/memory2 go2 autorecorder (dimensionalOS#1925) * Convert patrol module to be an async module (dimensionalOS#1939) * feat(tool-streams): add tool streams (dimensionalOS#1713) * G1 Low level connection module coordinator integration (dimensionalOS#1954) * feat(sim): MuJoCo sim teleop for xarm + piper (dimensionalOS#1958) * Show child process cpu usage in dtop (dimensionalOS#1880) Co-authored-by: leshy <lesh@sysphere.org> * Task: OpenArm Integration with DimOS (dimensionalOS#1897) Co-authored-by: Paul Nechifor <paul@nechifor.net> Co-authored-by: RD <63036454+ruthwikdasyam@users.noreply.github.com> Co-authored-by: Andrew Lauer <69774903+aclauer@users.noreply.github.com> Co-authored-by: leshy <lesh@sysphere.org> Co-authored-by: Jeff Hykin <jeff.hykin@gmail.com> * md-babel-py bump (dimensionalOS#1994) * new hong kong office recording (dimensionalOS#1991) * chore(security): update packages with issues (dimensionalOS#1989) * Make whisper an optional extra with faster-whisper by default (dimensionalOS#1877) * Drop perception. Update docs. (dimensionalOS#1888) * Add codecov (dimensionalOS#1889) * go2 lidar timestamps bugfix (dimensionalOS#1992) * go2 cli (dimensionalOS#1990) * refactor(core): memory2 for dtop (dimensionalOS#2004) * fix: adaptive timestamp correction (dimensionalOS#2021) Co-authored-by: Ivan Nikolic <lesh@sysphere.org> * Disable codecov status check (dimensionalOS#2026) * fixes replay mem leak (dimensionalOS#2025) * fix: launch arm blueprints with --simulation flag (dimensionalOS#2027) * small fixes for release (dimensionalOS#2019) * chore: add problems back * Change Codecov branch from 'dev' to 'main' * docs: remove mentions of dev * Ivan/fix/go2recording2 (dimensionalOS#2034) * mapper memory leak fix, measurement transforms (dimensionalOS#2031) * Feat/1759 doc codeblocks ci (dimensionalOS#1884) * Nav Stack 0.1 * fix(security): upgrade some packages (dimensionalOS#2040) * go2 apriltag recordings (dimensionalOS#2044) * Ivan/fix/doc codeblocks added skip2 (dimensionalOS#2052) * feat Aruco/Apriltag generator (dimensionalOS#2037) * Split tests off of self hosted runner (dimensionalOS#1901) Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * fix(verify): exclude unitree-dds extra to avoid cyclonedds C lib Upstream introduced `dimos[unitree-dds]` which depends on `cyclonedds==0.10.5`. The Python binding tries to compile against the CycloneDDS C library, which is not installed on the fork's ubuntu-latest runner. This makes verify fail with: Could not locate cyclonedds. Try to set CYCLONEDDS_HOME or CMAKE_PREFIX_PATH Upstream's own `ci.yml` (line 36) already passes `--no-extra dds --no-extra unitree-dds`; align the fork's verify with it. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: RD <63036454+ruthwikdasyam@users.noreply.github.com> Co-authored-by: Paul Nechifor <paul@nechifor.net> Co-authored-by: Mustafa Bhadsorawala <39084056+mustafab0@users.noreply.github.com> Co-authored-by: Sam Bull <git@sambull.org> Co-authored-by: Andrew Lauer <69774903+aclauer@users.noreply.github.com> Co-authored-by: leshy <lesh@sysphere.org> Co-authored-by: Jeff Hykin <jeff.hykin@gmail.com> Co-authored-by: stash <pomichterstash@gmail.com> Co-authored-by: Dan Vi <bogwi@tutamail.com> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Co-authored-by: jiangtao-huazhijian <jiang.tao@topsunpower.cc> Co-authored-by: Cursor <cursoragent@cursor.com>

Add codecov

fc4368b

Dreamsorcerer added 2 commits April 21, 2026 18:40

Update ci.yml

25048f7

Update ci.yml

7030052

Dreamsorcerer commented Apr 21, 2026

View reviewed changes

Comment thread .github/workflows/ci.yml Outdated

Apply suggestion from @Dreamsorcerer

25712d3

Dreamsorcerer marked this pull request as draft April 21, 2026 19:04

Dreamsorcerer added 3 commits April 22, 2026 14:49

Update ci.yml

c5cae4d

Merge branch 'dev' into codecov

6469e3c

Update ci.yml

ce6b7ec

Dreamsorcerer marked this pull request as ready for review April 22, 2026 14:13

greptile-apps Bot reviewed Apr 22, 2026

View reviewed changes

Comment thread .coveragerc.toml Outdated

Dreamsorcerer added 3 commits May 1, 2026 19:35

Refactor Codecov upload steps in CI workflow

8d08fc9

Updated coverage upload steps and adjusted paths.

Rename .coveragerc.toml to .coveragerc

3221bbd

Add write permission for id-token in CI workflow

e79c8cf

greptile-apps Bot reviewed May 1, 2026

View reviewed changes

Comment thread .github/workflows/ci.yml Outdated

Dreamsorcerer commented May 1, 2026

View reviewed changes

Comment thread .github/workflows/ci.yml Outdated

Apply suggestions from code review

082336e

Co-authored-by: Sam Bull <aa6bs0@sambull.org>

greptile-apps Bot reviewed May 1, 2026

View reviewed changes

Comment thread .coveragerc.toml Outdated

Comment thread .github/workflows/ci.yml

Dreamsorcerer commented May 1, 2026

View reviewed changes

Comment thread .github/workflows/ci.yml Outdated

Apply suggestion from @Dreamsorcerer

e3f6e85

greptile-apps Bot reviewed May 1, 2026

View reviewed changes

Comment thread .github/workflows/ci.yml

Dreamsorcerer added 4 commits May 1, 2026 20:19

Rename .coveragerc to .coveragerc.toml

e821c4d

Enhance coverage settings in pyproject.toml

1044ffe

Add coverage configuration options for branch, parallel, and exclusion patterns.

Delete .coveragerc.toml

80888f8

Merge branch 'dev' into codecov

4af835d

paul-nechifor approved these changes May 6, 2026

View reviewed changes

paul-nechifor merged commit 4b0cd6b into dev May 6, 2026
5 checks passed

paul-nechifor deleted the codecov branch May 6, 2026 22:14

mustafab0 pushed a commit that referenced this pull request May 13, 2026

Add codecov (#1889)

6e83a8f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add codecov#1889

Add codecov#1889
paul-nechifor merged 16 commits into
devfrom
codecov

Dreamsorcerer commented Apr 21, 2026

Uh oh!

greptile-apps Bot commented Apr 21, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented May 1, 2026 •

edited by codecov Bot

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Dreamsorcerer commented Apr 21, 2026

Uh oh!

greptile-apps Bot commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 4/5

Important Files Changed

Sequence Diagram

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented May 1, 2026 • edited by codecov Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

greptile-apps Bot commented Apr 21, 2026 •

edited

Loading

codecov-commenter commented May 1, 2026 •

edited by codecov Bot

Loading